Implement support for binary literals #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9il
reviewed
Nov 9, 2021
rv32ima
force-pushed
the
implement-binary-literals
branch
from
b9d3df2 to
4a365ac
Compare
Member
Author
|
Added in the test requested. Let me know if this needs anything else! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for binary literals. This code is incredibly similar to the code that is used for hex literal parsing, with some very minor modifications. As such, it suffers from the similar pitfalls (i.e. with underscores, it will over-allocate).
This feature is primarily needed for Mir Ion.